Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect /tokens api (#32085) #32092

Merged
merged 2 commits into from
Sep 22, 2024
Merged

Fix incorrect /tokens api (#32085) #32092

merged 2 commits into from
Sep 22, 2024

Conversation

GiteaBot
Copy link
Contributor

Backport #32085 by @KN4CK3R

Fixes #32078

  • Add missing scopes output.
  • Disallow empty scope.

@KN4CK3R @lunny @GiteaBot
Fix incorrect /tokens api (go-gitea#32085)
0110f3b 
Fixes go-gitea#32078

- Add missing scopes output.
- Disallow empty scope.

---------

Co-authored-by: Lunny Xiao <[email protected]>
@GiteaBot GiteaBot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code type/bug labels Sep 20, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 20, 2024
@GiteaBot GiteaBot added this to the 1.22.3 milestone Sep 20, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 20, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 20, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 20, 2024
@KN4CK3R KN4CK3R enabled auto-merge (squash) September 20, 2024 20:43
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 20, 2024
@KN4CK3R KN4CK3R merged commit 919b824 into go-gitea:release/v1.22 Sep 22, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfogre wolfogre wolfogre approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@lafriks lafriks lafriks approved these changes

@lunny lunny lunny approved these changes

@delvh delvh Awaiting requested review from delvh

Assignees

@KN4CK3R KN4CK3R

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.22.3
Development

Successfully merging this pull request may close these issues.
5 participants
@GiteaBot @lunny @lafriks @KN4CK3R @wolfogre